Fix dignity calculation: add detriment and fall (Venus in Aries now correctly shows detriment)

app.py

@@ -34,6 +34,28 @@ EXALTATIONS = {
     "Capricorn": "Mars", "Aquarius": None, "Pisces": "Venus"
 }
 
+# Detriments (opposite sign of domicile rulership)
+DETRIMENTS = {
+    "Sun": ["Aquarius"],
+    "Moon": ["Capricorn"],
+    "Mercury": ["Sagittarius", "Pisces"],
+    "Venus": ["Aries", "Scorpio"],
+    "Mars": ["Taurus", "Libra"],
+    "Jupiter": ["Gemini", "Virgo"],
+    "Saturn": ["Cancer", "Leo"]
+}
+
+# Falls (opposite sign of exaltation)
+FALLS = {
+    "Sun": ["Libra"],
+    "Moon": ["Scorpio"],
+    "Mercury": ["Pisces"],
+    "Venus": ["Virgo"],
+    "Mars": ["Cancer"],
+    "Jupiter": ["Capricorn"],
+    "Saturn": ["Aries"]
+}
+
 TRIPLICITIES = {
     "Fire": {"day": "Sun", "night": "Jupiter", "participating": "Saturn"},
     "Earth": {"day": "Venus", "night": "Moon", "participating": "Mars"},
@@ -149,6 +171,7 @@ def assess_planetary_dignity(planet: str, sign: str, is_day_chart: bool) -> str:
     """Assess a planet's essential dignity in a given sign"""
     dignity_score = 0
     dignities = []
+    debilities = []
 
     # Check domicile (+5)
     if DOMICILE_RULERS.get(sign) == planet:
@@ -174,7 +197,28 @@ def assess_planetary_dignity(planet: str, sign: str, is_day_chart: bool) -> str:
             dignity_score += 3
             dignities.append("Triplicity Ruler - Participating (+3)")
 
-    condition = "Strong" if dignity_score >= 4 else "Moderate" if dignity_score > 0 else "Peregrine"
+    # Check detriment (-5)
+    if sign in DETRIMENTS.get(planet, []):
+        dignity_score -= 5
+        debilities.append("Detriment (-5)")
+
+    # Check fall (-4)
+    if sign in FALLS.get(planet, []):
+        dignity_score -= 4
+        debilities.append("Fall (-4)")
+
+    # Determine condition based on score
+    if dignity_score <= -4:
+        condition = "Debilitated"
+    elif dignity_score < 0:
+        condition = "Weak"
+    elif dignity_score == 0:
+        condition = "Peregrine (no essential dignity)"
+    elif dignity_score <= 3:
+        condition = "Minor Dignity"
+    else:
+        condition = "Strong"
+
     chart_type = "Day Chart" if is_day_chart else "Night Chart"
 
     # Format as readable text
@@ -190,7 +234,12 @@ def assess_planetary_dignity(planet: str, sign: str, is_day_chart: bool) -> str:
         for dignity in dignities:
             result += f"✓ {dignity}\n"
     else:
-        result += "✗ No essential dignities (Peregrine)\n"
+        result += "○ No major dignities\n"
+
+    if debilities:
+        result += "\n### Debilities:\n"
+        for debility in debilities:
+            result += f"✗ {debility}\n"
 
     result += f"""
 **Total Dignity Score:** {dignity_score} points
@@ -198,14 +247,20 @@ def assess_planetary_dignity(planet: str, sign: str, is_day_chart: bool) -> str:
 
 ### Interpretation:
 """
-    if dignity_score >= 5:
+    if dignity_score <= -5:
+        result += f"{planet} is severely debilitated in {sign}, being in detriment. The planet struggles to express its nature and may act contrary to its essential significations."
+    elif dignity_score == -4:
+        result += f"{planet} is in fall in {sign}, a position of weakness. The planet cannot act with full strength and may produce difficult outcomes."
+    elif dignity_score < 0:
+        result += f"{planet} is weakened in {sign} with mixed conditions. The debilities outweigh any minor dignities present."
+    elif dignity_score == 0:
+        result += f"{planet} is peregrine in {sign}, having no essential dignity. The planet is like a stranger in a foreign land, neither particularly strong nor weak, but without support."
+    elif dignity_score <= 3:
+        result += f"{planet} has minor dignity in {sign}. The planet has some support but is not at full strength."
+    elif dignity_score >= 5:
         result += f"{planet} is very well-placed in {sign}, having its domicile or maximum dignity. The planet can act with full strength and autonomy."
-    elif dignity_score >= 4:
-        result += f"{planet} is strong in {sign}, with significant essential dignity. The planet functions well and can express its significations effectively."
-    elif dignity_score > 0:
-        result += f"{planet} has moderate dignity in {sign}. The planet has some support but is not at full strength."
     else:
-        result += f"{planet} is peregrine in {sign}, having no essential dignity. The planet is like a stranger in a foreign land and may struggle to act effectively."
+        result += f"{planet} is strong in {sign}, with significant essential dignity. The planet functions well and can express its significations effectively."
 
     return result